-
Notifications
You must be signed in to change notification settings - Fork 11
DOC: fix docs after package reorganization #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TODO: eventually, this should be removed from the repo
| del get_versions | ||
|
|
||
|
|
||
| from . import jet_control # noqa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
__all__ instead of noqa? Or just ignore this specific flake8 violation in setup.cfg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
__all__ would be for from .jet_control import * - which we probably don't want.
noqa, once flake8 checks are re-enabled, will make it exempt from flake8 checking. Without it, flake8 would complain that jet_control is imported but unused.
| .. autoclass:: jet_control.JetControl | ||
| .. autoclass:: JetControl | ||
|
|
||
| .. autosummary:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this render the autosummary table for all the stuff below? Never done it quite this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm updating these at the request of @koglin and keeping them as close as possible to what he originally had.
We should definitely standardize/overhaul this at some point down the line.
There's still a bunch of refactoring work to finish up, but I shouldn't have broken the docs completely.
TODO: need to move the built documentation out of the master branch.