Skip to content

Conversation

@klauer
Copy link
Contributor

@klauer klauer commented Oct 22, 2018

There's still a bunch of refactoring work to finish up, but I shouldn't have broken the docs completely.

TODO: need to move the built documentation out of the master branch.

@klauer klauer requested review from koglin and teddyrendahl October 22, 2018 17:04
del get_versions


from . import jet_control # noqa
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__all__ instead of noqa? Or just ignore this specific flake8 violation in setup.cfg?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__all__ would be for from .jet_control import * - which we probably don't want.

noqa, once flake8 checks are re-enabled, will make it exempt from flake8 checking. Without it, flake8 would complain that jet_control is imported but unused.

.. autoclass:: jet_control.JetControl
.. autoclass:: JetControl

.. autosummary::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this render the autosummary table for all the stuff below? Never done it quite this way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm updating these at the request of @koglin and keeping them as close as possible to what he originally had.

We should definitely standardize/overhaul this at some point down the line.

@klauer klauer merged commit b8007ab into pcdshub:master Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants