Skip to content
This repository was archived by the owner on Nov 6, 2021. It is now read-only.

Get disruption data from MVG-live#10

Merged
pc-coholic merged 2 commits into
pc-coholic:masterfrom
mountainsandcode:disruptions
May 18, 2017
Merged

Get disruption data from MVG-live#10
pc-coholic merged 2 commits into
pc-coholic:masterfrom
mountainsandcode:disruptions

Conversation

@mountainsandcode
Copy link
Copy Markdown
Contributor

@mountainsandcode mountainsandcode commented Apr 6, 2017

New method to crawl data and retrieve information about live disruptions from MVG-live.de

New method to crawl data on disruptions from MVG-live.de
@pc-coholic
Copy link
Copy Markdown
Owner

Thank you for this PR as well :)

I am just wondering though if we should use the API for this or stick to the RSS-Feed (http://www.mvg-mobil.de/Tickerrss/CreateRssClass) as I have done here: https://github.com/muccc/anzeigr/blob/master/current_nodes/mvgdefas/ticker/getmvgticker.py

The reason I am wondering is, that we don't know anything about the request-limits for the API - so offloading calls for the disruption-data to the RSS-feed might help us stay clear of any limits...

Or we offer both ways to get this data... Let me think about this a little :)

@mountainsandcode
Copy link
Copy Markdown
Contributor Author

Hadn't come across the RSS-feed, that would definitely be a convenient alternative. Good point about the request-limit as well, I think the RSS might be the way to go

@mountainsandcode
Copy link
Copy Markdown
Contributor Author

Had another look and I think the RSS is definitely the way to go. Having the timestamp alone makes that worth it. Perhaps you could reuse the code you linked to above?

@pc-coholic pc-coholic merged commit 1b33b36 into pc-coholic:master May 18, 2017
@pc-coholic
Copy link
Copy Markdown
Owner

Right now I do not have the time to properly integrate the RSS-feed into the library, so I am merging your PR and just mention the RSS-feed in the Readme.

Perhaps one day, we can integrate both and offer a switch or something like that.

Thanks for your contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants