#3179 fix: welcome dialog will be shown again

Signed-off-by: Patrizio Bekerle <[email protected]>

CHANGELOG.md

@@ -1,5 +1,9 @@
 # QOwnNotes Changelog
 
+## 24.12.4
+- The welcome wizard will now be shown again when the application runs for the first time,
+  this was a regression from 24.12.3 (for [#3179](https://github.com/pbek/QOwnNotes/issues/3179))
+
 ## 24.12.3
 - If the current note folder doesn't exist anymore during the start of the
   application, now the first existing one will be selected (for [#3179](https://github.com/pbek/QOwnNotes/issues/3179))

src/main.cpp

@@ -289,9 +289,10 @@ int mainStartupMisc(const QStringList &arguments) {
     DatabaseService::createConnection();
     DatabaseService::setupTables();
     QDir dir(notesPath);
+    bool existingNotesPathNotFound = !notesPath.isEmpty() && !dir.exists();
 
     // If this isn't the first run and the note folder doesn't exist anymore look for another one
-    if (!notesPath.isEmpty() && !dir.exists()) {
+    if (existingNotesPathNotFound) {
         notesPath = QString();
 
         // Loop through all note folders and select the first existing one
@@ -301,13 +302,14 @@ int mainStartupMisc(const QStringList &arguments) {
             if (dir.exists()) {
                 notesPath = noteFolder.getLocalPath();
                 noteFolder.setAsCurrent();
+                existingNotesPathNotFound = false;
                 break;
             }
         }
     }
 
-    // If there was no existing note folder found let the user select another one
-    if (notesPath.isEmpty()) {
+    // If there still was no existing note folder found let the user select another one
+    if (existingNotesPathNotFound) {
         if (QMessageBox::question(nullptr, QObject::tr("Note folder not found!"),
                                   QObject::tr("Your note folder <b>%1</b> was not found any more! "
                                               "Do you want to select a new one?")