#3184 fix: crash when accessing mimeData

Signed-off-by: Patrizio Bekerle <[email protected]>

CHANGELOG.md

@@ -1,5 +1,9 @@
 # QOwnNotes Changelog
 
+## 24.12.6
+- A possible crash when pasting HTML as Markdown or pasting as text file was fixed
+  (for [#3184](https://github.com/pbek/QOwnNotes/issues/3184))
+
 ## 24.12.5
 - Both note links and the link dialog are now supporting also heading 1, not only
   heading 2 and up, as long `#` headings are used (for [#3181](https://github.com/pbek/QOwnNotes/issues/3181)) 

src/mainwindow.cpp

@@ -7156,15 +7156,20 @@ void MainWindow::handleInsertingFromMimeData(const QMimeData *mimeData) {
         const QPoint globalPos = textEdit->mapToGlobal(rect.bottomRight());
         QMenu menu;
 
+        // We need to fetch the text and html from the mime data here, because the mimeData object
+        // may not be available anymore after the menu was closed and accessing it may cause a crash
+        const auto text = mimeData->text();
+        const auto html = mimeData->html();
+
         QAction *htmlAction = menu.addAction(tr("Paste &HTML as Markdown"));
         QAction *textAttachmentAction = menu.addAction(tr("Paste as &text file attachment"));
         QAction *selectedItem = menu.exec(globalPos);
 
         if (selectedItem == htmlAction) {
-            insertHtmlAsMarkdownIntoCurrentNote(mimeData->html());
+            insertHtmlAsMarkdownIntoCurrentNote(html);
         } else if (selectedItem == textAttachmentAction) {
             // Insert text as attachment file
-            insertTextAsAttachment(mimeData->text());
+            insertTextAsAttachment(text);
         }
     }
 }