Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #15

Closed
wants to merge 2 commits into from
Closed

Fix typos #15

wants to merge 2 commits into from

Conversation

fredster33
Copy link

No description provided.

@pbatard
Copy link
Owner

pbatard commented Aug 19, 2021

Thanks for the Pull Request. Unfortunately this requires a bit more involvement than simply fixing the English page, as all the translations also need to be updated, and a small alteration like this usually results in GetText failing to match the English version of the text with its translation... Basically every single github that's used in any translation (including .po and .mo files) needs to be replaced with GitHub. But one also needs to make sure that links to GitHub (https://(.*)github.com(.*)) are not altered.

This is going to require quite a bit of work, so I'm probably going to delay this low priority request for some time...

@fredster33
Copy link
Author

Oop. I'll create a little regex and clone locally. It'll probably take roughly 2 hours for me to get back to a computer and commit, and I'll be done.

@pbatard
Copy link
Owner

pbatard commented Aug 20, 2021

You'll need to regenerate the .mo... which aren't text files.

For the record here is what an update like yours should look like (where we switched our CD/DVD burning applications recommendations). So that's more than 150 files that need to get updated...

I used this python script to go through the .po/.mo update, and I'm planning to reuse something similar to go through yours, so you don't have to bother.

It's just going to take me a while to do so, even with a script, because it's low priority.

And yeah, I'd like to move away from this madness of having to internally use gettext on a local server to ultimately generate static pages that can be served by GitHub, but GitHub are not at all sympathetic to adding proper localization support to GitHub pages.

@fredster33
Copy link
Author

Ah, got it. Yeah, the Jekyll localization support is really bad. Well, thanks, I'll wait for you to use the script. This is definitely low priority :)

@fredster33
Copy link
Author

Going to close this PR for now, assuming that you'll push commits to the main repo

@fredster33 fredster33 closed this Sep 14, 2021
@pbatard pbatard mentioned this pull request Sep 14, 2021
@pbatard
Copy link
Owner

pbatard commented Sep 14, 2021

I'd rather keep it open, as it's low priority and, even if I'm not going to apply this PR as is, I need a reminder that I have some work to do here. 😉

Unfortunately, since you deleted your branch, I can't reopen this PR so I created issue #16.

pbatard added a commit that referenced this pull request Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants