Skip to content

refactor: Feature/payloadfields#1260

Merged
saikiran-m7 merged 5 commits intopaypal:developfrom
saikiran-m7:feature/payloadfields
Feb 2, 2026
Merged

refactor: Feature/payloadfields#1260
saikiran-m7 merged 5 commits intopaypal:developfrom
saikiran-m7:feature/payloadfields

Conversation

@saikiran-m7
Copy link
Copy Markdown
Collaborator

Description

Update all references to payload fields to match the name that gets sent in the request.
Locate and identify usage of old fpti key names in the logger for paypal-messaging-components.

Screenshots

Testing instructions

Comment thread src/utils/logger.js
buyer_profile_hash = buyer_profile_hash ?? trackingDetails.BUYER_PROFILE_HASH;
buyer_profile_valid = buyer_profile_valid ?? trackingDetails.BUYER_PROFILE_VALID;
partner_attribution_id = partner_attribution_id ?? stats.bn_code;
partner_attribution_id = partner_attribution_id ?? stats.partner_attribution_id;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does partner_attribution_id already exist on the stats object?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's there in Stats. However, I see the changes need to be done only in 2 files. If anything I missed please do let me know.
image

Copy link
Copy Markdown
Contributor

@perco12 perco12 Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct me if I am wrong, but you will also need to update bn_code in stats.js to be partner_attribuition_id or its going to be undefined when it looks for stats.partner_attribuition_id.
Location in stats.js

Copy link
Copy Markdown
Contributor

@perco12 perco12 Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to add on to that, do we also need to update all other locations that are using bn_code like here or just in logger @JordanClemons ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should yeah

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JordanClemons @perco12 Resolved the comments. Please review and let me know the changes.

@saikiran-m7 saikiran-m7 changed the title Refactor: Feature/payloadfields refactor: Feature/payloadfields Feb 2, 2026
@saikiran-m7 saikiran-m7 merged commit cae48fe into paypal:develop Feb 2, 2026
66 checks passed
github-actions Bot pushed a commit that referenced this pull request Feb 3, 2026
## [1.77.0](v1.76.1...v1.77.0) (2026-02-03)

### Features

* add experiment gating for US and GB preapproval badge ([#1270](#1270)) ([237fe7e](237fe7e))

### Bug Fixes

* country-specific margins for preapproval label in checkout header ([#1266](#1266)) ([aed68db](aed68db))

### Code Refactoring

* Feature/payloadfields ([#1260](#1260)) ([cae48fe](cae48fe))
* finalize message type values ([#1252](#1252)) ([49d63d7](49d63d7))
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 3, 2026

🎉 This PR is included in version 1.77.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants