Skip to content

refactor: finalize message type values #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremy-herman merged 3 commits into from
Feb 3, 2026
Merged

refactor: finalize message type values #1252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b0da43
update values
yeul Dec 16, 2025
566983a
add additional value
yeul Dec 16, 2025
8167285
update
yeul Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/messages/CA/generic.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"id": "",
"offerCountry": "CA",
"offerType": "GENERIC",
"messageType": "GENERIC",
"messageType": "PL_GENERIC",
"offerTerm": "${CREDIT_OFFERS_DS.total_payments}",
"lander": "",
"variables": {
Expand Down
2 changes: 1 addition & 1 deletion content/messages/CA/generic_fr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"offerCountry": "CA",
"language": "fr-CA",
"offerType": "GENERIC",
"messageType": "GENERIC",
"messageType": "PL_GENERIC",
"offerTerm": "${CREDIT_OFFERS_DS.total_payments}",
"lander": "",
"variables": {
Expand Down
2 changes: 1 addition & 1 deletion content/messages/DE/generic-non-de.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"meta": {
"offerCountry": "DE",
"offerType": "GENERIC",
"messageType": "GENERIC_XB",
"messageType": "PL_GENERIC_XB",
"offerTerm": "{total_payments}",
"lander": "",
"variables": {
Expand Down
2 changes: 1 addition & 1 deletion content/messages/DE/generic.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"meta": {
"offerCountry": "DE",
"offerType": "GENERIC",
"messageType": "GENERIC",
"messageType": "PL_GENERIC",
"offerTerm": "{total_payments}",
"lander": "",
"variables": {
Expand Down
4 changes: 2 additions & 2 deletions content/messages/ES/short_term_no_amount.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"meta": {
"offerCountry": "ES",
"offerType": "PAY_LATER_SHORT_TERM",
"messageType": "PLST_NA",
"offerType": "GENERIC",
"messageType": "PL_GENERIC",
"offerTerm": "{total_payments}",
"lander": "",
"variables": {
Expand Down
4 changes: 2 additions & 2 deletions content/messages/IT/short_term_no_amount.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"meta": {
"offerCountry": "IT",
"offerType": "PAY_LATER_SHORT_TERM",
"messageType": "PLST_NA",
"offerType": "GENERIC",
"messageType": "PL_GENERIC",
"offerTerm": "{total_payments}",
"lander": "",
"variables": {
Expand Down
2 changes: 1 addition & 1 deletion content/messages/US/buttons/generic_pay_later.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"id": "",
"offerCountry": "US",
"offerType": "GENERIC",
"messageType": "GENERIC_PL",
"messageType": "PP:PL_GENERIC",
"lander": "https://www.paypal.com/credit-presentment/lander/modal"
},
"headline": [["Pay in full or Pay Later", ["default", "xsmall"]]],
Expand Down
2 changes: 1 addition & 1 deletion content/messages/US/buttons/generic_pay_later_bnpl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"id": "",
"offerCountry": "US",
"offerType": "GENERIC",
"messageType": "GENERIC",
"messageType": "PL_GENERIC",
"lander": "https://www.paypal.com/credit-presentment/lander/modal"
},
"headline": [
Expand Down
2 changes: 1 addition & 1 deletion content/messages/US/buttons/generic_paypal.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"id": "",
"offerCountry": "US",
"offerType": "GENERIC",
"messageType": "GENERIC_PAYPAL",
"messageType": "PP_GENERIC",
"lander": "https://www.paypal.com/credit-presentment/lander/modal"
},
"headline": [["A safer, easier way to pay", ["default", "xsmall"]]],
Expand Down
2 changes: 1 addition & 1 deletion content/messages/US/generic.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"id": "d8dbfe8b-0bb8-44b1-ae07-6f32816fafe6",
"offerCountry": "US",
"offerType": "GENERIC",
"messageType": "GENERIC",
"messageType": "PL_GENERIC",
"offerTerm": "${CREDIT_OFFERS_DS.total_payments}",
"lander": "https://www.paypal.com/ppclander",
"variables": {
Expand Down
3 changes: 2 additions & 1 deletion content/messages/US/long_term_multi_gtz_3mez.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"meta": {
"id": "d8dbfe8b-0bb8-44b1-ae07-6f32816fafe6",
"offerCountry": "US",
"offerType": "LT_MQGZ:3MEZ",
"offerType": "PAY_LATER_LONG_TERM",
"messageType": "PLLT_MQ_GZ:PLLT_SQ_EZ",
"offerTerm": "${CREDIT_OFFERS_DS.total_payments}",
"lander": "https://www.paypal.com/ppclander",
"variables": {
Expand Down
2 changes: 1 addition & 1 deletion content/messages/US/marks/generic_pay_later.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"id": "",
"offerCountry": "US",
"offerType": "GENERIC",
"messageType": "GENERIC_PL",
"messageType": "PP:PL_GENERIC",
"lander": "https://www.paypal.com/credit-presentment/lander/modal"
},
"headline": [["Pay in full or Pay Later", ["default", "xsmall"]]],
Expand Down
2 changes: 1 addition & 1 deletion content/messages/US/marks/generic_pay_later_bnpl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"id": "",
"offerCountry": "US",
"offerType": "GENERIC",
"messageType": "GENERIC",
"messageType": "PL_GENERIC",
"lander": "https://www.paypal.com/credit-presentment/lander/modal"
},
"headline": [["Buy now, pay later", ["default", "xsmall"]]],
Expand Down
2 changes: 1 addition & 1 deletion content/messages/US/marks/generic_paypal.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"id": "",
"offerCountry": "US",
"offerType": "GENERIC",
"messageType": "GENERIC_PAYPAL",
"messageType": "PP_GENERIC",
"lander": "https://www.paypal.com/credit-presentment/lander/modal"
},
"headline": [["A safer, easier way to pay", ["default", "xsmall"]]],
Expand Down
6 changes: 3 additions & 3 deletions demo/helpers/accounts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ const accounts = [
// 'DEV0000ESPLNQ',
// 'DEV0000ESPLNA',
// 'DEV0000ESPLTQ',
// 'DEV0000ESPLTNQ'
// 'DEV000ESPLTNQ',

// AU
// 'DEV000000AUPL',
Expand All @@ -89,9 +89,9 @@ const accounts = [
// IT
// 'DEV0000ITPLNA',
// 'DEV00000ITPLQ',
// 'DEV0000ITPLNQ'
// 'DEV0000ITPLNQ',
// 'DEV0000ITPLTQ',
// 'DEV0000ITPLTNQ'
// 'DEV000ITPLTNQ',

// CA
// 'DEV000ENCAPLQ',
Expand Down
10 changes: 5 additions & 5 deletions docs/message-types.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ The following are abbreviations used in reference to various messages and files.

| messageType | PStudio Name | File Name | Message |
| --------------- | -------------------- | -------------------------- | ------------------------------------------------------------------------------- |
| GENERIC | Generic Message | generic | Pay Later - No Amount Message |
| PL_GENERIC | Generic Message | generic | Pay Later - No Amount Message |
| PLST_SQ | Short Term - Q | short_term_q | Pay Later - Pay in 4, Qualifying Purchase |
| PLST_NQ | Short Term - NQ | short_term_nq | Pay Later - Pay in 4, Non-Qualifying Purchase |
| PLLT_MQ_EZ | Long Term - MQEZ | long_term_multi_eqz | Pay Later - Pay Monthly, Multiple Qualifying Offers = 0% APR |
Expand Down Expand Up @@ -44,8 +44,8 @@ The following are abbreviations used in reference to various messages and files.
| PLLT_MQ_GZ | DE Long Term - Q GTZ | gplq_gtz | Pay Later - Ratenzahlung, Non-Qualifying Offers, >0% APR |
| PLP1_SQ_XB | DE Pay In 1 - Q NON-DE | pi30q-non-de | Pay Later - Pay in 1, Non-DE, Qualifying Purchase |
| PIP1_SQ | DE Pay In 1 - Q | pi30q | Pay Later - Pay in 1, Qualifying Purchase |
| GENERIC_XB | DE Generic Message - NON-DE | generic-non-de | Pay Later - Non-DE, No Amount Message |
| GENERIC | DE Generic Message | generic | Pay Later - No Amount Message |
| PL_GENERIC_XB | DE Generic Message - NON-DE | generic-non-de | Pay Later - Non-DE, No Amount Message |
| PL_GENERIC | DE Generic Message | generic | Pay Later - No Amount Message |
| PLP1_NQ_XB | DE Pay In 1 - NQ NON-DE | pi30nq-non-de | Pay Later - Pay in 1, Non-DE, Non-Qualifying Purchase |
| PLP1_NQ | DE Pay In 1 - NQ | pi30nq | Pay Later - Pay in 1, Non-Qualifying Purchase |
| PLLT_NQ_EZ_XB | DE Long Term - NQ EQZ NON-DE | gpl_eqz-non-de | Pay Later - Ratenzahlung, Non-DE, Non-Qualifying Purchase, 0% APR |
Expand Down Expand Up @@ -85,15 +85,15 @@ The following are abbreviations used in reference to various messages and files.

| messageType | PStudio Name | File Name | Message |
| ----------- | ------------------ | -------------------- | -------------------------------------------- |
| PLST_NA | IT Short Term - NA | short_term_no_amount | Pay Later, Pay in 3, No Amount |
| PL_GENERIC | IT Short Term - NA | short_term_no_amount | Pay Later, Pay in 3, No Amount |
| PLST_SQ | IT Short Term - Q | short_term_q | Pay Later, Pay in 3, Qualifying Purchase |
| PLST_NQ | IT Short Term - NQ | short_term_nq | Pay Later, Pay in 3, Non-Qualifying Purchase |

### **ES (Spain)**

| messageType | PStudio Name | File Name | Message |
| ----------- | ------------------ | -------------------- | -------------------------------------------- |
| PLST_NA | ES Short Term - NA | short_term_no_amount | Pay Later, Pay in 3, No Amount |
| PL_GENERIC | ES Short Term - NA | short_term_no_amount | Pay Later, Pay in 3, No Amount |
| PLST_SQ | ES Short Term - Q | short_term_q | Pay Later, Pay in 3, Qualifying Purchase |
| PLST_NQ | ES Short Term - NQ | short_term_nq | Pay Later, Pay in 3, Non-Qualifying Purchase |

Expand Down
1 change: 1 addition & 0 deletions src/server/locale/CA/mutations/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export default function getMutations(id, type) {
case 'PLST_NQ':
return shortTermNQ[type];
case 'GENERIC':
case 'PL_GENERIC':
default:
return generic[type];
}
Expand Down
1 change: 1 addition & 0 deletions src/server/locale/ES/mutations/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ export default function getMutations(id, type) {
return shortTermNq[type];
case 'SHORT_TERM:NO_AMOUNT':
case 'PLST_NA':
case 'PL_GENERIC':
default:
return shortTermNoAmount[type];
}
Expand Down
1 change: 1 addition & 0 deletions src/server/locale/IT/mutations/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ export default function getMutations(id, type) {
return shortTermNq[type];
case 'SHORT_TERM:NO_AMOUNT':
case 'PLST_NA':
case 'PL_GENERIC':
default:
return shortTermNoAmount[type];
}
Expand Down
3 changes: 3 additions & 0 deletions src/server/locale/US/CONTEXTUAL_COMPONENTS/BUTTONS/mutations/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,18 @@ export default function getMutations(id, type) {
// Generic Messages
// Generic Pay Later message
case 'GENERIC_PL':
case 'PP:PL_GENERIC':
return genericPayLater[type];
// // Generic Pay Later - Buy now, Pay Later message
case 'GENERIC_PL_BNPL':
case 'GENERIC':
case 'PL_GENERIC':
return genericPayLaterBNPL[type];
case 'PURCHASE_PROTECTION':
return purchaseProtection[type];
// // Generic PayPal message
case 'GENERIC_PAYPAL':
case 'PP_GENERIC':
default:
return genericPayPal[type];
}
Expand Down
3 changes: 3 additions & 0 deletions src/server/locale/US/CONTEXTUAL_COMPONENTS/MARKS/mutations/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,18 @@ export default function getMutations(id, type) {
// Generic Messages
// Generic Pay Later message
case 'GENERIC_PL':
case 'PP:PL_GENERIC':
return genericPayLater[type];
// // Generic Pay Later - Buy now, Pay Later message
case 'GENERIC_PL_BNPL':
case 'GENERIC':
case 'PL_GENERIC':
return genericPayLaterBNPL[type];
case 'PURCHASE_PROTECTION':
return purchaseProtection[type];
// // Generic PayPal message
case 'GENERIC_PAYPAL':
case 'PP_GENERIC':
default:
return genericPayPal[type];
}
Expand Down
1 change: 1 addition & 0 deletions src/server/locale/US/PAY_LATER_LONG_TERM/mutations/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ export default function getMutations(id, type) {
return longTermMultiGTZ[type];
case 'LT_MQGZ:3MEZ':
case 'PLLT_MQGZ:3MEZ':
case 'PLLT_MQ_GZ:PLLT_SQ_EZ':
return longTermMultiGTZ3MEZ[type];
case 'LT_SQEZ':
case 'PLLT_SQ_EZ':
Expand Down
1 change: 1 addition & 0 deletions src/utils/miscellaneous.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ export function getStandardProductOffer(offer) {
case 'LT_MQEZ_RB':
case 'LT_MQGZ':
case 'LT_MQGZ:3MEZ':
case 'PLLT_MQ_GZ:PLLT_SQ_EZ':
case 'LT_SQEZ':
case 'LT_SQEZ_RB':
case 'LT_SQGZ':
Expand Down
Loading