Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix xpc_darwin.go avoid cgoCheckPointer #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix xpc_darwin.go avoid cgoCheckPointer #70

wants to merge 1 commit into from
+33 −21

Conversation

kmtr
Copy link

@kmtr kmtr commented Mar 30, 2016

change type
unsafe.Pointer => C.uintptr_t(uintptr(unsafe.Pointer))

ref golang/go#12416

and fix test.

@dongri
Copy link

dongri commented Mar 30, 2016

👍

@dongri
Copy link

dongri commented Mar 30, 2016

💯

@sleeper sleeper mentioned this pull request May 7, 2016
Closed
rusq
rusq approved these changes Jan 11, 2020
View reviewed changes
Copy link

@rusq rusq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusq rusq rusq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmtr @dongri @rusq