Skip to content
This repository was archived by the owner on Jul 20, 2020. It is now read-only.

Conversation

@pauljv92
Copy link

@pauljv92 pauljv92 commented Sep 4, 2018

Make sure you have checked all steps below.

GitHub Issue

Fixes #47

Checklist:

  • This pull request updates the documentation
  • This pull request changes library dependencies
  • Title of the PR is of format (example) : [[#14] Add Issue Template #17] Add Issue Template

What is the purpose of this pull request?

Part 1 of Unittests

How was this change validated?

Run with these commands: ipython -c "import nose; nose.run()" AND nosetests --with-coverage --cover-package=ppextensions/

Commit Guidelines

  • My commits all reference GH issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message"

@praveen-kanamarlapudi
Copy link
Contributor

Can you fix the PR Quality Review checks?

@pauljv92 pauljv92 force-pushed the testcases_part1 branch 2 times, most recently from 082e78b to efb32e4 Compare September 4, 2018 23:25
@pauljv92
Copy link
Author

pauljv92 commented Sep 4, 2018

@praveenkanamarlapudi done!

Copy link
Contributor

@praveen-kanamarlapudi praveen-kanamarlapudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Leaving for others to review.


class TestPPSqlHiveConnection(unittest.TestCase):

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT - can we avoid these changes

@praveen-kanamarlapudi
Copy link
Contributor

@pauljv92 Can you rebase and update the PR?

@pauljv92
Copy link
Author

pauljv92 commented Dec 7, 2018

@praveenkanamarlapudi sure will do!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants