Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(richtext-lexical): fix all eslint errors to get react compiler running on all files, enable strict: true #9394

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

AlessioGr
Copy link
Member

@AlessioGr AlessioGr commented Nov 21, 2024

This PR fixes all eslint errors in the richtext-lexical package. This includes all eslint errors of the react compiler.

Since the react compiler skips files that have react compiler eslint errors, this PR will make it run on files it previously ignored.

Source: https://react.dev/learn/react-compiler#installing-eslint-plugin-react-compiler

The ESLint plugin will display any violations of the rules of React in your editor. When it does this, it means that the compiler has skipped over optimizing that component or hook. This is perfectly okay, and the compiler can recover and continue optimizing other components in your codebase.

This PR also enables strict: true. Thanks to @GermanJablo for doing most of the work by enabling noImplicitAny and strictNullChecks in previous PRs

@AlessioGr AlessioGr changed the title chore(richtext-lexical): enable strict: true perf(richtext-lexical): fix all eslint errors to get react compiler running on all files, enable strict: true Nov 21, 2024
@AlessioGr AlessioGr merged commit 48b60fc into main Nov 21, 2024
52 checks passed
@AlessioGr AlessioGr deleted the chore/lexical-strict-true branch November 21, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant