fix: getPayload generate import map only in Next.js, move ws dependency to @payloadcms/next
#9371
+18
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ency to `@payloadcms/next`
r1tsuu
force-pushed
the
fix/get-payload-without-next-js
branch
from
03cffa2
to
925cb03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the change with removing
getPayloadHMR, we do generate import map even outside of Next.js, which leads to errors when using in a project without it:Also, the
wsdependency shouldn't be included to thepayloadpackage, instead we can move it@payloadcms/nextand import dynamically and we shouldn't try to connect to the Next.js WebSocket server if we're not inside of Next.js.Now, to control this we use the
PAYLOAD_NEXT_INTEGRATION = 'true'env variable which we add inwithPayload.