fix: correct migrations sorting in getMigrations
#9330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
We sorted migrations by
-name
ingetMigrations
as by assumption from generated file names, however, it may be not true as the improved (+ unflaked, previously it failed sometimes) test formigrate:down
can reproduce. As in result,migrateDown
/migrateRefresh
may execute in order different frommigrate
.Unflakes the 'should commit multiple operations async' test.
We shouldn't pass the same
req
that doesn't contain a transaction to different operations that execute in parallel (viaPromise.all
) without either creating a transaction before or usingisolateObjectProperty(req, 'transactionID')
. It leads to a race condition because operation can commit a wrong transaction, different from inited