feat(richtext-lexical): wrapper blocks #9289
Draft
+1,116
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
This is the last one in the holy trinity of lexical block types. After this, most editor features that one can imagine can be implemented using just the BlocksFeature, without having to worry about creating custom features and interfacing with the lexical API.
This includes things like color pickers, text fonts pickers and even links.
I am contemplating about moving the LinkFeature to use wrapper blocks, as 90% of code is duplicative. However, we will probably keep the LinkNodes, as they are used very frequently and the DX of having a dedicated link node with strong typing is nicer.
Example screenshots - API not final