feat: replace qs with picoquery across codebase #6954
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's faster, doesn't add bloated polyfills, is ESM-only and has a smaller bundle size.
https://bundlephobia.com/package/[email protected] (2.1kb)
https://bundlephobia.com/package/[email protected] (11kb)
https://www.npmjs.com/package/picoquery?activeTab=readme
I don't agree with the backwards philosophy of qs: ljharb/qs#404 (comment) ("more deps is better", lower bundle size as opt-in, maximum environment compatibility as opt-out)
QS:
https://npm.anvaka.com/#/view/2d/qs
Picoquery:
https://npm.anvaka.com/#/view/2d/picoquery
qs imports waaay too many useless dependencies
Before merging, we should check if there are any security loopholes in this new package. It's not as battle-tested as qs