-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix: conditional tabs breaking in Next.js 16 due to unstable tab id #15270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+35
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlessioGr
commented
Jan 20, 2026
| */ | ||
| description?: LabelFunction | StaticDescription | ||
| fields: Field[] | ||
| // TODO: Deprecate this in front of a schemaPath property on every field |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- id property is confusing since we only store the schemaPath there
- storing the schemaPath in there for every field will make config traversal in other areas of the codebase simpler and faster - we would only ever need to calculate the path again, not the schema path
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
jacobsfletch
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes broken conditional tabs support in Next.js 16. In Next.js 16, the config is sanitized multiple times during development, with each run assigning a new UUID to
tab.id. This causes a mismatch between thetab.idin form state and thetab.idin the client config - likely because the client config is cached, while config sanitization is not.Using UUIDs in form state is also inconsistent with the rest of the codebase, where every other field uses its path as a key. This PR replaces the random UUID with the tab's schema path, ensuring a stable ID regardless of how many times config sanitization runs, and aligning tabs closer to how other fields are keyed in form state.