fix: add beforeOperation hook in findVersions collections operations #14737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imsidkg
changed the title
Contributor
|
Hi @imsidkg, thanks for creating this PR to the issue I opened! During a discussion with r1tsuu in the Discord, he noticed that the |
Author
|
sure @jhb-dev i will work on it. |
Contributor
DanRibbens
reviewed
Dec 4, 2025
Contributor
DanRibbens
left a comment
DanRibbens
left a comment
There was a problem hiding this comment.
We are going to close this PR in favor of #14778 which solves the same issue and is more thorough.
Thanks for the PR and drawing attention to this issue though! I would love to get you in as a contributor on another PR on the next one.
| } = args | ||
|
|
||
| const req = args.req! | ||
| const { fallbackLocale, locale, payload } = req |
Contributor
There was a problem hiding this comment.
This is redundant with the above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the beforeOperation collection hook being called when using the findVersions operation, just as it is for the standard find operation.
Why?
Previously, the beforeOperation hook was only triggered for standard find operations, but not for findVersions. This led to inconsistent behavior, as custom logic (such as access control, logging, or argument modification) defined in beforeOperation would not run when querying document versions. This PR brings parity and predictability to hook execution across both operations.
How?
The logic for invoking the beforeOperation hook (as seen in find.ts) was added to findVersions.ts.
Now, when findVersions is called, all registered beforeOperation hooks are executed with the correct arguments before the main operation logic runs.
Fixes
#14726