-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix: ensure importMap is reliably generated during HMR (fixes Next.js 16 issue) #14474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
AlessioGr
commented
Nov 5, 2025
| importMapFile?: string | ||
| rootDir: string | ||
| }) { | ||
| }): Promise<Error | string> { |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this fn is not exported. => not breaking
paulpopus
approved these changes
Nov 5, 2025
Contributor
|
🚀 This is included in version v3.63.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14419
Problem
Next.js 16 changes the order of
getPayload()calls during HMR. In testing, the frontend now callsgetPayload()before the admin panel does. Since the frontend typically hasskipImportMapGeneration: true(due to no importMap passed togetPayload), this was skipping import map generation entirely, breaking the admin panel.Solution
This PR ensures the import map is always regenerated during HMR by passing
falseas the second parameter toreload(), regardless of theoptions.importMapvalue passed togetPayload().Additionally, a new
ignoreResolveErroroption is added to handle cases wheregetPayload()is called exclusively from the frontend (where no import map file exists). This prevents errors from interrupting the HMR process in frontend-only scenarios.