Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): properly filters fields from list view columns and conditions #10246

Merged
merged 17 commits into from
Dec 30, 2024

Conversation

jacobsfletch
Copy link
Member

@jacobsfletch jacobsfletch commented Dec 30, 2024

Fixes #10234. Some fields, such as focal point fields for upload enabled collections, were rendering in the condition selector despite being hidden from the column selector. This was because the logic for the column selector was filtering fields without labels, but the same was not being done for the filter conditions. This, however, is not a good way to filter these fields as it requires this specific logic to be written in multiple places. Instead, they need to explicitly check for hidden and disabled in addition to disableListFilter and disableListColumn. The actual filtering logic has been improved across the two instances as well, removing multiple duplicative loops.

This change has also exposed a underlying issue with the way columns were handled within the table columns provider. When row selections were enabled, the selector columns were present in column state. This caused problems when interacting with column indices, such as when reordering columns. Instead of needing to manually filter these out every time we need to work with column state, they no longer appear there in the first place. Instead, we inject the row selectors directly into the table itself, completely isolating these row selectors from the column state.

…proves logic and moves tests to proper suite
@jacobsfletch jacobsfletch changed the title fix(ui): properly filters focalX and focalY fields from condition selector fix(ui): filters focalX and focalY fields from condition selector Dec 30, 2024
@jacobsfletch jacobsfletch enabled auto-merge (squash) December 30, 2024 17:04
@jacobsfletch jacobsfletch changed the title fix(ui): filters focalX and focalY fields from condition selector fix(ui): filters hidden fields from condition selector Dec 30, 2024
@jacobsfletch jacobsfletch changed the title fix(ui): filters hidden fields from condition selector fix(ui): properly filters fields from list view columns and conditions Dec 30, 2024
@jacobsfletch jacobsfletch enabled auto-merge (squash) December 30, 2024 23:09
@jacobsfletch jacobsfletch merged commit f5a955d into main Dec 30, 2024
67 checks passed
@jacobsfletch jacobsfletch deleted the fix/filter-columns branch December 30, 2024 23:39
Copy link
Contributor

github-actions bot commented Jan 2, 2025

🚀 This is included in version v3.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant