Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTime picker in sidebar gets cut off #165

Closed
Ontopic opened this issue May 5, 2021 · 5 comments · Fixed by #183
Closed

DateTime picker in sidebar gets cut off #165

Ontopic opened this issue May 5, 2021 · 5 comments · Fixed by #183

Comments

@Ontopic
Copy link
Contributor

Ontopic commented May 5, 2021

Bug Report

When a DateTime field has position: 'sidebar' the time dropdown is cut off

Possible Solution

.collection-edit__sidebar-sticky {
  overflow: initial;

  .date-time-picker .react-datepicker-popper {
    right: 0 !important;
    left: initial !important;
  }
}

Possibly better to just set overflow-x

Is how I now fix it in the scss override, probably best to move something like this to the core though (the sidebar never fits the calendar atm). Making sure you guys agree with this direction and I can clean up my hacks and turn it into a proper PR.

@Ontopic Ontopic added the bug label May 5, 2021
@jmikrut
Copy link
Member

jmikrut commented May 6, 2021

Hey @Ontopic — thank you for the report! We will be addressing this today and will release a new version immediately afterward.

@jmikrut
Copy link
Member

jmikrut commented May 10, 2021

Update: we've got a bit more involved of a solution in mind here, as we'd like to keep overflow: auto on the .collection-edit__sidebar-sticky element. Setting overflow: initial removes the ability for the sidebar to be sticky and / or vertically scroll when taller than the viewport, unfortunately.

Going to pick back up on this shortly. Just wanted to provide an update here that we do have an idea for how to fix this and it's on its way!

jmikrut added a commit that referenced this issue May 16, 2021
…xpress-fileupload schema validation (#180)

* fix: misc responsive improvements
* fix: date clipping in sidebar
* fix: revises popup
* fix: admin _verified field not displaying proper field value
* fix: properly typed express-fileupload config options
@jmikrut
Copy link
Member

jmikrut commented May 16, 2021

Hey @Ontopic — this is now fixed! We went with a solution similar to what you can see here:

https://codepen.io/toomuchdesign/pen/RKLGba

And then a little more magic here and there of course.

Thanks for identifying this!

@Ontopic
Copy link
Contributor Author

Ontopic commented May 17, 2021

Went a looked at how you fixed it. Nice and elegant.

Copy link
Contributor

github-actions bot commented Sep 8, 2024

This issue has been automatically locked.
Please open a new issue if this issue persists with any additional detail.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants