Fix NTAG UID for multi-cascade anti-collision#362
Merged
Conversation
In ISO 14443-3 anti-collision, multi-byte UIDs (7 or 10 bytes) span multiple cascade levels. Intermediate levels prefix UID parts with a cascade tag byte (0x88) that must be excluded from the final UID. The FM175xx driver was appending the full `UID_part` at every level, including the cascade tag of intermediate levels, yielding a corrupt UID. Strip the first byte from `UID_part` for all levels except the last so the assembled UID contains only the actual tag bytes.
✅ Build ArtifactsVersion:
|
Copilot AI
pushed a commit
to justinh-rahb/SnapmakerU1-Extended-Firmware
that referenced
this pull request
Mar 31, 2026
In ISO 14443-3 anti-collision, multi-byte UIDs (7 or 10 bytes) span multiple cascade levels. Intermediate levels prefix UID parts with a cascade tag byte (0x88) that must be excluded from the final UID. The FM175xx driver was appending the full `UID_part` at every level, including the cascade tag of intermediate levels, yielding a corrupt UID. Strip the first byte from `UID_part` for all levels except the last so the assembled UID contains only the actual tag bytes. Co-authored-by: justinh-rahb <52832301+justinh-rahb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ISO 14443-3 anti-collision, multi-byte UIDs (7 or 10 bytes) span multiple cascade levels. Intermediate levels prefix UID parts with a cascade tag byte (0x88) that must be excluded from the final UID.
The FM175xx driver was appending the full
UID_partat every level, including the cascade tag of intermediate levels, yielding a corrupt UID.Strip the first byte from
UID_partfor all levels except the last so the assembled UID contains only the actual tag bytes.