Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Linux crash lines (#64, #114) #115

Merged
merged 2 commits into from
Sep 7, 2016
Merged

Conversation

ziggi
Copy link
Contributor

@ziggi ziggi commented Sep 5, 2016

Fix for #64, #114.

Just removed two lines that give a crash. I've tested this very much and it pretty stable.

Why it stable? Because in latest Pawn these lines also does not exist: sc3.c#L2331-L2333. And I think it's a good reason to remove this.

@oscar-broman
Copy link
Contributor

Doesn't this remove tag checking for forwarded functions, or functions used before they are declared?

@Y-Less
Copy link
Member

Y-Less commented Sep 5, 2016

The latest PAWN compiler is almost a completely different language. I wouldn't trust that as an example of what can be changed. There's also no guarantee that they haven't just been moved or implemented differently. I'm with Oscar - do you know what they were there for, removing lines does imply removing functionality and they clearly do something with tags.

@oscar-broman
Copy link
Contributor

The problem is not that line. The problem is that arg[argidx].tags has an invalid value. When I inspected it in gdb, I saw 0x4 - and it's a pointer!

Something has gone wrong before it reached this line.

@oscar-broman
Copy link
Contributor

@ziggi
Copy link
Contributor Author

ziggi commented Sep 7, 2016

Seems to it really works, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants