__emit: Fix undefined behavior

Apparently shifting a 32-bit signed value by 31 bits is UB
pawn-lang · Jun 7, 2019 · bad16ae · bad16ae
1 parent 991eed9
commit bad16ae
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/source/compiler/sc1.c b/source/compiler/sc1.c
@@ -6314,7 +6314,7 @@ static int SC_FASTCALL emit_param_any_internal(emit_outval *p,int expected_tok,
   case tRATIONAL:
     if (!allow_nonint)
       goto invalid_token;
-    p->value.ucell=(ucell)(negate ? (val|((cell)1 << (PAWN_CELL_SIZE-1))) : val);
+    p->value.ucell=(negate ? ((ucell)val|((ucell)1 << (PAWN_CELL_SIZE-1))) : (ucell)val);
     break;
   case tSYMBOL:
     sym=findloc(str);

diff --git a/source/compiler/sc2.c b/source/compiler/sc2.c
@@ -1405,7 +1405,7 @@ static int command(void)
               break;
             } else if (current_token==tRATIONAL) {
               /* change the first bit to make float negative value */
-              outval(val|((cell)1 << (PAWN_CELL_SIZE-1)),FALSE);
+              outval(val|(cell)((ucell)1 << (PAWN_CELL_SIZE-1)),FALSE);
               code_idx+=opargs(1);
               break;
             } else {