Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aria2c Input File Support #91

Merged
merged 4 commits into from
Apr 4, 2021
Merged

Aria2c Input File Support #91

merged 4 commits into from
Apr 4, 2021

Conversation

jonnieey
Copy link
Contributor

@jonnieey jonnieey commented Apr 2, 2021 •
edited by pawamoy
Loading

Issue #70

pawamoy
pawamoy requested changes Apr 2, 2021
View reviewed changes
Copy link
Owner

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few things to update 🙂

src/aria2p/api.py Outdated Show resolved Hide resolved
src/aria2p/api.py Outdated Show resolved Hide resolved
src/aria2p/api.py Outdated Show resolved Hide resolved
src/aria2p/api.py Outdated Show resolved Hide resolved
src/aria2p/api.py Outdated Show resolved Hide resolved
src/aria2p/api.py Outdated Show resolved Hide resolved
src/aria2p/api.py Outdated Show resolved Hide resolved
src/aria2p/api.py Outdated Show resolved Hide resolved
src/aria2p/api.py Outdated Show resolved Hide resolved
src/aria2p/api.py Outdated Show resolved Hide resolved
@pawamoy
Copy link
Owner

pawamoy commented Apr 2, 2021

Oh, you can also rebase on master to fix the Poetry error in CI.

pawamoy
pawamoy reviewed Apr 3, 2021
View reviewed changes
src/aria2p/api.py Outdated Show resolved Hide resolved
pawamoy
pawamoy reviewed Apr 3, 2021
View reviewed changes
src/aria2p/api.py Outdated Show resolved Hide resolved
@pawamoy
Copy link
Owner

pawamoy commented Apr 3, 2021

Oh, I almost forgot: could you add tests for this? You can create the tests/data/input_files directory and create some valid and invalid files, then write some tests in test_api.py for split_input_file and/or parse_input_file.

@jonnieey
Copy link
Contributor Author

jonnieey commented Apr 3, 2021

Oh, I almost forgot: could you add tests for this? You can create the tests/data/input_files directory and create some valid and invalid files, then write some tests in test_api.py for split_input_file and/or parse_input_file.

Okay. 👍

pawamoy
pawamoy approved these changes Apr 4, 2021
View reviewed changes
Copy link
Owner

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great! Ready to merge?

@jonnieey
Copy link
Contributor Author

jonnieey commented Apr 4, 2021

That's great! Ready to merge?

Okay. 👍

@pawamoy pawamoy merged commit a603961 into pawamoy:master Apr 4, 2021
@pawamoy pawamoy mentioned this pull request Apr 5, 2021
Closed
@jonnieey jonnieey deleted the add-input-file branch April 5, 2021 20:59
@pawamoy pawamoy mentioned this pull request Nov 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawamoy pawamoy pawamoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonnieey @pawamoy