library: use timeouts

[Dobatymo]

Sometimes network calls can block forever if no timeouts are specified. For example here

aria2p/src/aria2p/client.py

Line 324 in 56d7d7a

return requests.post(self.server, data=payload).json()

It would be good if a timeout could be passed to requests.

Maybe it could be specified globally for the client like Client(..., timeout=60) and then use requests.post(..., timeout=self.timeout).

[pawamoy]

Very good idea 😄

Nice implementation suggestion as well. I'll do this.

Do you think we should put a default timeout? If yes, how many seconds?

[Dobatymo]

Yes, I think a default timeout would be useful, Probably a long timeout like 60 or 120 seconds. Because users probably don't expect that operations can potentially block forever.
I don't know why requests doesn't use a default timeout. But I think missing timeouts are a common source of errors in network programming.

[pawamoy]

Thanks, then I'll use a default timeout of 60 seconds.

[pawamoy]

Released in 0.9.0.

You can use the global -T option to set the timeout in floating seconds.