Repository navigation
ci(edge): run Windows checks and releases on Node 24.21.0, past the libuv exit abort - #277
Merged
Merged
Conversation
…ibuv exit abort Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
Validation on Node v24.21.0 (confirmed in the job log): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the intermittent Windows CI crash (exit code
3221226505=0xC0000409) by moving the pinned Node from 24.15.0 to 24.21.0.Evidence
Across the last 80 Edge CI runs,
edge / windows release checksaborted with0xC0000409eight times:Assertion failed: !(handle->flags & UV_HANDLE_CLOSING), file src\win\async.c, line 76.session.integration.mjswithin 2–15 s of a mode's start, before any test output. That is where wrangler'sunstable_devstarts and stops the released-state seeder. They exited with the same status; no assertion text reached the log.This is the known Node bug nodejs/node#56645. A platform worker thread posts a delayed task after the scheduler's
uv_asynchandle started closing at exit, so Windows libuv aborts. nodejs/node#61999 ("src: fix libuv assertion on windows") fixed it in 24.20.0 (CHANGELOG_V24.md). The same0xC0000409hits release publish jobs, which run the same checks on Windows; today it would fail a tag and force a new version number.Why 24.21.0, not 24.20.0
release-edge.ymlstayed on 24.15.0 because 24.16+ could abort Windows file watchers when runner temp uses an 8.3 short path, until nodejs/node#65118. That fix shipped in 24.21.0. 24.21.0 is the first release with both fixes, so.node-version,edge-ci.yml'sWINDOWS_NODE_VERSION, andrelease-edge.yml'sNODE_VERSIONall move to it. The stale comment is replaced with one covering both.Validation
This PR's own
edge / windows release checksruns on 24.21.0. The crash is intermittent (about 1 in 10 runs here), so I will rerun that job a few times before merging and report the results.🤖 Generated with Claude Code