TouchMode.ALL optimization

intercept touch events for both TouchMode vales. In the case of my app, BifacialView is inside a ViewPager. Everything is ok with TouchMode.DELIMITER, but touch gestures were confusing using TouchMode.ALL (BifacialView sets new position, but parent viewPager starts swiping too!). This fixes my bug :)
pavel163 · Sep 11, 2017 · bc6a236 · bc6a236
1 parent 4a40f7a
commit bc6a236
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/library/src/main/java/com/ebr163/bifacialview/view/BifacialView.java b/library/src/main/java/com/ebr163/bifacialview/view/BifacialView.java
@@ -168,22 +168,18 @@ public boolean onTouchEvent(MotionEvent event) {
 
         switch (event.getAction()) {
             case MotionEvent.ACTION_DOWN:
-                if (touchMode == TouchMode.DELIMITER) {
-                    if (x > delimiterPosition + delimiterPadding || x < delimiterPosition - delimiterPadding) {
-                        return false;
-                    } else {
-                        getParent().requestDisallowInterceptTouchEvent(true);
-                    }
+                if ((touchMode == TouchMode.DELIMITER) &&
+                        (x > delimiterPosition + delimiterPadding || x < delimiterPosition - delimiterPadding)) {
+                    return false;
                 }
+                getParent().requestDisallowInterceptTouchEvent(true);
             case MotionEvent.ACTION_MOVE:
                 isMove = true;
                 break;
             case MotionEvent.ACTION_UP:
             case MotionEvent.ACTION_CANCEL:
                 isMove = false;
-                if (touchMode == TouchMode.DELIMITER) {
-                    getParent().requestDisallowInterceptTouchEvent(false);
-                }
+                getParent().requestDisallowInterceptTouchEvent(false);
                 break;
         }
         delimiterPosition = (int) (x / 1);