Fix build with Boost 1.89.0#1038
Merged
pavel-odintsov merged 1 commit intopavel-odintsov:masterfrom Aug 18, 2025
Merged
Conversation
41 tasks
Owner
|
Hello! Thank very much for PR and all the background story! Let's check if it works fine this way and then we will remove it completely. |
Owner
|
I completely removed dependency on system and it works fine now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the upcoming Boost 1.89.0 release, Boost.System stub library has been removed (boostorg/system@7a495bb) which causes a CMake error.
I noticed this while testing 1.89.0.beta1 in Homebrew Homebrew/homebrew-core#233031.
Moved
systemto OPTIONAL_COMPONENTS based on upstream suggestion at boostorg/system#132 (comment)Though there is a TODO comment mentioning not needing
systemso an alternative could be to remove it. This is definitely safe for Boost 1.691 or newer where Boost.System is header-only though would need confirmation on older Boost.Footnotes
https://www.boost.org/doc/libs/1_69_0/libs/system/doc/html/system.html#changes_in_boost_1_69 ↩