Fedora linter, Forbidden function symbols found: inet_addr inet_aton inet_ntoa

[pavel-odintsov]

We've got following warning from Fedora's linter: https://osci-jenkins-1.ci.fedoraproject.org/job/fedora-ci/job/rpminspect-pipeline/job/master/104394/testReport/(root)/tests/_badfuncs/

The reason of such warning is well described here: https://github.com/rpminspect/rpminspect-data-fedora/blob/master/fedora.yaml#L719

I think we need to review our approach for these functions if possible.

[pavel-odintsov]

Examples:

fastnetmon/src/sflow_plugin/sflow_collector.cpp

Line 210 in bec1b5f

servaddr.sin_addr.s_addr = inet_addr(interface_for_binding.c_str());

fastnetmon/src/fast_library.cpp

Line 57 in ce2eddc

inet_aton(ip.c_str(), &ip_addr);

fastnetmon/src/fast_library.cpp

Line 63 in ce2eddc

std::string convert_ip_as_uint_to_string(uint32_t ip_as_integer) {

[pavel-odintsov]

We get rid of one of them actually as part of project to port to Windows.

[pavel-odintsov]

One more fix in sFlow logic