This repository has been archived by the owner on Oct 29, 2020. It is now read-only.
Add New Relic Infrastructure API support #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paultyng Gentle ping here, just as I'm very keen to see these changes downstream in the NewRelic Terraform provider :) |
paultyng
suggested changes
May 21, 2018
| @@ -14,6 +14,20 @@ type Client struct { | |||
| RestyClient *resty.Client | |||
| } | |||
|
|
|||
| // InfraClient represents the client state for the Infrastructure API | |||
| type InfraClient struct { | |||
There was a problem hiding this comment.
I'm not as familiar with this part of the New Relic API, so Infra is an entirely separate API (including a separate endpoint) I take it?
There was a problem hiding this comment.
That's correct—separate endpoint.
api/alert_infra_conditions.go
Outdated
| "strconv" | ||
| ) | ||
|
|
||
| func (i *InfraClient) queryAlertInfraConditions(policyID int) ([]AlertInfraCondition, error) { |
There was a problem hiding this comment.
i is probably a bad name for this due to its more idiomatic usage, looping, etc, maybe just c or cli or something that evokes client?
|
Thanks for the feedback, I will address this later today. |
|
@paultyng updated the InfraClient variable name to be more consistent with the rest of the project. |
paultyng
approved these changes
May 21, 2018
|
Released as v1.6.0 |
ianrayns
pushed a commit
to ianrayns/go-newrelic
that referenced
this pull request
May 7, 2019
Add NRQL Alert Condition Resource
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @smithclay in https://github.com/terraform-providers/terraform-provider-newrelic/pull/30
Let me know if this is what you had in mind. This adds New Relic Infrastructure API support.