Skip to content

Add main/module fields to package.json#37

Merged
paulmillr merged 1 commit into
paulmillr:mainfrom
jacogr:jg-main-module-package
Dec 12, 2021
Merged

Add main/module fields to package.json#37
paulmillr merged 1 commit into
paulmillr:mainfrom
jacogr:jg-main-module-package

Conversation

@jacogr
Copy link
Copy Markdown
Contributor

@jacogr jacogr commented Dec 12, 2021

With package root imports relies on the main/module fields, see https://github.com/jacogr/test-noble-packaging (parcel/webpack bundles correctly, browserify needs the main field otherwise it doesn't find it)

@paulmillr paulmillr merged commit 4544cbb into paulmillr:main Dec 12, 2021
@paulmillr
Copy link
Copy Markdown
Owner

Same with noble hashes pls

@jacogr
Copy link
Copy Markdown
Contributor Author

jacogr commented Dec 12, 2021

@noble/hashes do work since we don't import from root package, rather via lib/blake2 etc. Or at least, the above linked repo only complains on secp256k1, no issues on hashes in there. (However, it we ever do export everything from index.ts as well, the same should be applied)

@jacogr jacogr deleted the jg-main-module-package branch December 12, 2021 07:37
@achingbrain
Copy link
Copy Markdown

Any chance of this being released please? It should fix builds that use browserify.

This was referenced Dec 13, 2021
@paulmillr
Copy link
Copy Markdown
Owner

1.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants