Support dependency descriptor and two-byte header for RTP header extension #1127
+626
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melpon
force-pushed
the
dependency-descriptor
branch
2 times, most recently
from
fad4131 to
0f9a96e
Compare
melpon
force-pushed
the
dependency-descriptor
branch
from
0f9a96e to
cadffd5
Compare
|
We have added an RTP header extension to our WebRTC SFU to determine AV1 payloads without parsing them. I know this will be hard to review, but please consider merging if you like. |
Co-authored-by: Paul-Louis Ageneau <[email protected]>
|
Thank you for the code review. I have fixed all the pointed-out issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the Dependency Descriptor RTP Header Extension in
AV1RtpPacketizer. This allows SFUs to determine the dependencies between frames and the presence of keyframes without inspecting the RTP payload, enabling them to appropriately forward video frames.Additionally, since the body size of the DD could become larger than 16 bytes, I also implemented the Two-Byte Header.