Refuse to inline when there are readonly violations

Reviewed By: paulbiss Differential Revision: D30701228 fbshipit-source-id: b186e7ef48349b23db70d0088a8103ae200d742a
paulbiss · Sep 2, 2021 · 4b3a784 · 4b3a784
1 parent d425808
commit 4b3a784
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/hphp/runtime/vm/jit/inlining-decider.cpp b/hphp/runtime/vm/jit/inlining-decider.cpp
@@ -172,6 +172,14 @@ bool checkNumArgs(SrcKey callSK,
     }
   }
 
+  if (fca.enforceMutableReturn() && (callee->attrs() & AttrReadonlyReturn)) {
+    return refuse("caller requries mutable return but callee is readonly return");
+  }
+
+  if (fca.enforceReadonlyThis() && !(callee->attrs() & AttrReadonlyThis)) {
+    return refuse("caller expects no modifications to the instance but callee does modify");
+  }
+
   return true;
 }