This repository has been archived by the owner on Mar 20, 2022. It is now read-only.
Add support for circular references #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptshih
force-pushed
the
circulardependencies
branch
from
d2866cc
to
f295fc1
Compare
ptshih
force-pushed
the
circulardependencies
branch
from
f295fc1
to
2f4fe33
Compare
paularmstrong
suggested changes
May 29, 2018
|
Thanks for the comments @paularmstrong - I'll tinker around this weekend to try and address the above concerns. |
Remove the use of `JSON.stringify` for comparing equality; instead use `Array.prototype.some` to check equality
|
@paularmstrong - I made some improvements based on your feedback; it's definitely a much cleaner implementation now. |
|
@paularmstrong bumping this |
|
Would be great to have this merged! |
|
@paularmstrong Just curious if there is any reason not to merge this PR? |
|
I just hit this issue. Is there any remaining work on this to get this ready to merge? |
3 tasks
paularmstrong
approved these changes
Mar 6, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Unable to normalize inputs with circular references. I get a
maximum call stack size exceedederror.Solution
This PR is based on #330 with a few changes (based on the fixes recommended there):
Array.prototype.somefor equality check instead ofSetto avoid a polyfilltoMatchSnapshotTODO