Skip to content

Commit

Permalink
[api] Fix compilation error for UNIMPLEMENTED() method
Browse files Browse the repository at this point in the history
Return `nullptr` from `ArrayBuffer::Allocator::Reserve` because
apparently not doing so results in compile errors for some people.

BUG=

Ref: nodejs/node#13392
Review-Url: https://codereview.chromium.org/2929993003
Cr-Commit-Position: refs/heads/master@{#45886}
  • Loading branch information
addaleax authored and Commit Bot committed Jun 13, 2017
1 parent 91fb26e commit f14d1b6
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/api.cc
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,10 @@ void V8::SetSnapshotDataBlob(StartupData* snapshot_blob) {
i::V8::SetSnapshotBlob(snapshot_blob);
}

void* v8::ArrayBuffer::Allocator::Reserve(size_t length) { UNIMPLEMENTED(); }
void* v8::ArrayBuffer::Allocator::Reserve(size_t length) {
UNIMPLEMENTED();
return nullptr;
}

void v8::ArrayBuffer::Allocator::Free(void* data, size_t length,
AllocationMode mode) {
Expand Down

0 comments on commit f14d1b6

Please sign in to comment.