Add support for additional job arguments in Spark EKS job context #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds support for custom job arguments in Spark EKS job configuration to enhance flexibility in job execution. This allows users to specify additional arguments beyond the default parameters when configuring Spark jobs.
- Added an
Argumentsfield to thesparkEksJobContextstruct to accept custom arguments - Updated the argument construction logic in
applySparkOperatorConfigto use custom arguments when provided - Enhanced the conditional logic to handle three scenarios: return result mode, custom arguments mode, and default mode
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
hladush
reviewed
Oct 6, 2025
| mainAppFile := s3aWrapperURI | ||
| if jobContext.ReturnResult { | ||
| sparkApp.Spec.Arguments = []string{execCtx.appName, s3aQueryURI, execCtx.job.User, s3aResultURI} | ||
| } else if len(jobContext.Arguments) > 0 { |
There was a problem hiding this comment.
what if ReturnResult true and Arguments are provided? what should be happened?
There was a problem hiding this comment.
Please check now
sanketjadhavSF
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for passing custom arguments to Spark EKS jobs, enhancing flexibility in job configuration. The changes allow users to specify additional arguments that will be included when the job is executed, in addition to the existing parameter options.
Enhancement to Spark EKS job configuration:
Argumentsfield to thesparkEksJobContextstruct, allowing users to specify a slice of custom arguments for Spark jobs.applySparkOperatorConfigfunction to use the newArgumentsfield: ifReturnResultis false andArgumentsare provided, the job's argument list is constructed using the app name, user, and the custom arguments.