DATA-5849: File download support #51
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| package ecs | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "strings" | ||
|
|
||
| "github.com/aws/aws-sdk-go-v2/aws" | ||
| ) | ||
|
|
||
| // ContainerOption is a function that modifies container overrides | ||
| type ContainerOption func(*executionContext) error | ||
|
|
||
| // ApplyContainerOptions applies a list of container options to container overrides | ||
| func ApplyContainerOptions(execCtx *executionContext, options ...ContainerOption) error { | ||
| for _, option := range options { | ||
| if err := option(execCtx); err != nil { | ||
| return err | ||
| } | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| // WithFileUploadScript wraps container commands with a script that downloads files from S3 to the container | ||
| func WithFileUploadScript(fileUploads []FileUpload, localDir string) ContainerOption { | ||
| return func(execCtx *executionContext) error { | ||
| if len(fileUploads) == 0 { | ||
| return nil | ||
| } | ||
|
|
||
| for i := range execCtx.ContainerOverrides { | ||
| override := &execCtx.ContainerOverrides[i] | ||
|
|
||
| // Get the original command from override, or from task definition if not overridden | ||
| var originalCommand []string | ||
| if len(override.Command) > 0 { | ||
| originalCommand = override.Command | ||
| } else { | ||
| // Get command from task definition | ||
| for _, container := range execCtx.TaskDefinitionWrapper.TaskDefinition.ContainerDefinitions { | ||
| if aws.ToString(container.Name) == aws.ToString(override.Name) { | ||
| originalCommand = container.Command | ||
| break | ||
| } | ||
| } | ||
| } | ||
|
|
||
| if len(originalCommand) == 0 { | ||
| originalCommand = []string{} | ||
| } | ||
|
|
||
| // Generate the download wrapper script | ||
| wrapperScript := generateDownloadWrapperScript(fileUploads, localDir, originalCommand) | ||
|
|
||
| // Replace container command with wrapper script | ||
| override.Command = []string{"sh", "-c", wrapperScript} | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
| } | ||
|
|
||
| const downloadScriptTemplate = ` | ||
|
There was a problem hiding this comment. the general rule is to put constants on the top of the file. You can also consider the option to move it to the separate file |
||
| set -e | ||
| apk update && apk add aws-cli | ||
| mkdir -p {{LOCAL_DIR}} | ||
| for s3_path in {{S3_PATHS}};do aws s3 cp "$s3_path" "{{LOCAL_DIR}}/$(basename "$s3_path")" 2>&1;done | ||
| exec {{CMD}}` | ||
|
|
||
| // generateDownloadWrapperScript generates a minimal bash script that downloads files from S3 and executes the original command | ||
| func generateDownloadWrapperScript(fileUploads []FileUpload, localDir string, originalCommand []string) string { | ||
| // Build S3 paths list for the for loop | ||
| var s3Paths []string | ||
| for _, upload := range fileUploads { | ||
| s3Paths = append(s3Paths, fmt.Sprintf(`"%s"`, upload.S3Destination)) | ||
| } | ||
| s3PathsList := strings.Join(s3Paths, " ") | ||
|
|
||
| // Build command string | ||
| cmdStr := "wait" | ||
| if len(originalCommand) > 0 { | ||
| escapedCmd := make([]string, len(originalCommand)) | ||
| for i, arg := range originalCommand { | ||
| escapedCmd[i] = fmt.Sprintf("'%s'", strings.ReplaceAll(arg, "'", "'\\''")) | ||
| } | ||
| cmdStr = strings.Join(escapedCmd, " ") | ||
| } | ||
|
|
||
| // Fill template | ||
| script := strings.ReplaceAll(downloadScriptTemplate, "{{LOCAL_DIR}}", localDir) | ||
| script = strings.ReplaceAll(script, "{{S3_PATHS}}", s3PathsList) | ||
| script = strings.ReplaceAll(script, "{{CMD}}", cmdStr) | ||
| return script | ||
| } | ||
|
|
||
| // Future container options can be added here as needed | ||
|
There was a problem hiding this comment. You can add it as a comment in PR, but when time comes people will figure out how to do that |
||
| // Example: | ||
| // func WithEnvironmentVariables(envVars map[string]string) ContainerOption { ... } | ||
| // func WithHealthCheck(config HealthCheckConfig) ContainerOption { ... } | ||
| // func WithResourceLimits(limits ResourceLimits) ContainerOption { ... } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with file download script? Name doesn't match description