chore: upgrade deprecated components in demo-app #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenny-s51
changed the title
jenny-s51
force-pushed
the
upgradeDeprecatedComponents_demo-app
branch
from
da6ea7b
to
247a7a0
Compare
jenny-s51
force-pushed
the
upgradeDeprecatedComponents_demo-app
branch
from
9760ccc
to
72461c2
Compare
fix import error and update contextmenuseparator component
jenny-s51
force-pushed
the
upgradeDeprecatedComponents_demo-app
branch
from
b3b88cf
to
2f5661b
Compare
|
Dropdown menus no longer close on click outside the menu. |
|
Node context menus have strange semi-transparent arrow: |
jeff-phillips-18
approved these changes
Aug 23, 2023
nicolethoen
reviewed
Sep 7, 2023
| </div> | ||
| </DropdownContextDeprecated.Provider> | ||
| <div className={css(styles.dropdown, styles.modifiers.expanded)}> | ||
| <Dropdown toggle={() => <></>} className={css(topologyStyles.topologyContextMenuCDropdownMenu)}> |
There was a problem hiding this comment.
I'm noticing that the old dropdowns in the context menu demo would close after you select an item. IDK if that's a built in behavior or a quirk of the demo. Just checking it was an intended change?
There was a problem hiding this comment.
Thank you @nicolethoen , good find. Updated
nicolethoen
approved these changes
Sep 8, 2023
|
🎉 This PR is included in version 5.1.0-prerelease.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #92