Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config updates to retire v5 #89

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Config updates to retire v5 #89

merged 1 commit into from
Aug 16, 2023

Conversation

jenny-s51
Copy link
Collaborator

@jenny-s51 jenny-s51 commented Aug 10, 2023 •
edited
Loading

What

Towards #88

Description

Config updates to v5 branch

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): branch retirement process

Screen shots / Gifs for design review

nicolethoen
nicolethoen reviewed Aug 11, 2023
View reviewed changes
Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think to be sure we know what to expect, the title of this commit should begin with fix:

packages/module/release.config.js Outdated Show resolved Hide resolved
@jeff-phillips-18 jeff-phillips-18 merged commit eea240b into patternfly:v5 Aug 16, 2023
4 checks passed
@jenny-s51 jenny-s51 deleted the retire_v5 branch August 16, 2023 18:44
@github-actions
Copy link

🎉 This PR is included in version 5.1.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-phillips-18 jeff-phillips-18 jeff-phillips-18 approved these changes

@nicolethoen nicolethoen nicolethoen approved these changes

@wise-king-sullyman wise-king-sullyman Awaiting requested review from wise-king-sullyman

Assignees
No one assigned
Labels
released on @prerelease
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenny-s51 @jeff-phillips-18 @nicolethoen