Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated components #84

Merged
merged 3 commits into from
Aug 14, 2023

Conversation

jenny-s51
Copy link
Collaborator

@jenny-s51 jenny-s51 commented Jul 28, 2023

What

Towards #69

Description

Updates deprecated v4 components to their v5 counterparts

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

@jenny-s51 jenny-s51 marked this pull request as draft July 28, 2023 12:45
@jenny-s51 jenny-s51 changed the title Update deprecated components WIP: Update deprecated components Jul 28, 2023
@jenny-s51 jenny-s51 linked an issue Aug 10, 2023 that may be closed by this pull request
@jenny-s51 jenny-s51 marked this pull request as ready for review August 14, 2023 15:42
@jenny-s51 jenny-s51 changed the title WIP: Update deprecated components Update deprecated components Aug 14, 2023
@jeff-phillips-18
Copy link
Member

This change is only for the PF docs portion correct? Will there be a follow-up for the examples (demo-app)?

@jenny-s51
Copy link
Collaborator Author

This change is only for the PF docs portion correct? Will there be a follow-up for the examples (demo-app)?

Yes @jeff-phillips-18 , will open a separate PR for the demo-app changes. Tracking here #69

Copy link
Member

@jeff-phillips-18 jeff-phillips-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff-phillips-18 jeff-phillips-18 merged commit a382158 into patternfly:v5 Aug 14, 2023
4 checks passed
@jenny-s51 jenny-s51 linked an issue Aug 15, 2023 that may be closed by this pull request
@github-actions
Copy link

🎉 This PR is included in version 5.1.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants