Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TaskPill): fix customStatusIcon bug #229

Merged
merged 1 commit into from
Aug 6, 2024
Merged

fix(TaskPill): fix customStatusIcon bug #229

merged 1 commit into from
Aug 6, 2024

Conversation

jenny-s51
Copy link
Collaborator

What

Closes #227

Description

  1. Go to http://custom-status-fix.surge.sh
  2. Navigate to PIpelines -> Task Nodes demo
  3. Verify that customStatusIcon is applied

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

Before
Screenshot 2024-08-02 at 4 29 49 PM

After
Screenshot 2024-08-02 at 4 21 45 PM

@patternfly-build
Copy link

Preview: https://react-topology-pr-topology-229.surge.sh

@dlabaj dlabaj merged commit 68492bb into patternfly:main Aug 6, 2024
8 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

🎉 This PR is included in version 5.4.0-prerelease.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlabaj dlabaj dlabaj approved these changes

@jeff-phillips-18 jeff-phillips-18 jeff-phillips-18 approved these changes

Assignees
No one assigned
Labels
released on @prerelease
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: customStatusIcon does not get applied
4 participants
@jenny-s51 @patternfly-build @dlabaj @jeff-phillips-18