feat(FileUpload): added event params to callbacks#8960
Merged
nicolethoen merged 1 commit intopatternfly:v5from Apr 27, 2023
Merged
feat(FileUpload): added event params to callbacks#8960nicolethoen merged 1 commit intopatternfly:v5from
nicolethoen merged 1 commit intopatternfly:v5from
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-8960.surge.sh A11y report: https://patternfly-react-pr-8960-a11y.surge.sh |
Contributor
|
On the v5 branch (patternfly-react-v5.surge.sh) for this component opens the upload dialog twice before it successfully uploads the file and displays it in the file-details textarea. |
wise-king-sullyman
force-pushed
the
FileUpload-add-event-params
branch
from
f0903f9 to
a913531
Compare
Collaborator
Author
|
@nicolethoen rebased after merging the FileUpload fix, I think it's good now? |
thatblindgeye
approved these changes
Apr 26, 2023
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Examples are working fine for me now
nicolethoen
approved these changes
Apr 27, 2023
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #8881
Additional issues:
The
onTextChangecb was already updated as part of #8955