Skip to content

chore(Dropdown): remove deprecated props #8179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 2 commits into from
Oct 13, 2022
Merged

chore(Dropdown): remove deprecated props #8179

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f97bf6
chore(Dropdown): remove deprecated props
andyyvo Oct 5, 2022
c489f1e
chore(Dropdown): cleaning up lint comment
andyyvo Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/react-core/src/components/Dropdown/DropdownItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ export interface DropdownItemProps extends Omit<InternalDropdownItemProps, 'tabI
isAriaDisabled?: boolean;
/** Render dropdown item as non-interactive item */
isPlainText?: boolean;
/** @deprecated Forces display of the hover state of the element */
isHovered?: boolean;
/** Default hyperlink location */
href?: string;
/** Tooltip to display when hovered over the item */
Expand Down
4 changes: 0 additions & 4 deletions packages/react-core/src/components/Dropdown/DropdownMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ export interface DropdownMenuProps {
className?: string;
/** Flag to indicate if menu is opened */
isOpen?: boolean;
/** @deprecated - no longer used */
openedOnEnter?: boolean;
/** Flag to indicate if the first dropdown item should gain initial focus, set false when adding
* a specific auto-focus item (like a current selection) otherwise leave as true
*/
Expand Down Expand Up @@ -51,7 +49,6 @@ export class DropdownMenu extends React.Component<DropdownMenuProps> {
static defaultProps: DropdownMenuProps = {
className: '',
isOpen: true,
openedOnEnter: false,
autoFocus: true,
position: DropdownPosition.left,
component: 'ul',
Expand Down Expand Up @@ -180,7 +177,6 @@ export class DropdownMenu extends React.Component<DropdownMenuProps> {
isGrouped,
setMenuComponentRef,
// eslint-disable-next-line @typescript-eslint/no-unused-vars

@nicolethoen nicolethoen Oct 12, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment still necessary?

@andyyvo andyyvo Oct 12, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this also apply to the comment on line 130 as well @nicolethoen ?

@nicolethoen nicolethoen Oct 12, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i does not

openedOnEnter,
alignments,
...props
} = this.props;
Expand Down
6 changes: 1 addition & 5 deletions packages/react-core/src/components/Dropdown/DropdownToggle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ export interface DropdownToggleProps extends React.HTMLProps<HTMLButtonElement>,
isText?: boolean;
/** Whether or not the <div> has a disabled state */
isDisabled?: boolean;
/** @deprecated Use `toggleVariant` instead. Whether or not the dropdown toggle button should have primary button styling */
isPrimary?: boolean;
/** Alternate styles for the dropdown toggle button */
toggleVariant?: 'primary' | 'secondary' | 'default';
/** An image to display within the dropdown toggle, appearing before any component children */
Expand Down Expand Up @@ -65,7 +63,6 @@ export const DropdownToggle: React.FunctionComponent<DropdownToggleProps> = ({
isDisabled = false,
isPlain = false,
isText = false,
isPrimary = false,
toggleVariant = 'default',
// eslint-disable-next-line @typescript-eslint/no-unused-vars
isActive = false,
Expand Down Expand Up @@ -97,7 +94,6 @@ export const DropdownToggle: React.FunctionComponent<DropdownToggleProps> = ({
isDisabled={isDisabled}
isPlain={isPlain}
isText={isText}
isPrimary={isPrimary}
toggleVariant={toggleVariant}
onToggle={onToggle}
aria-haspopup={ariaHasPopup}
Expand All @@ -123,7 +119,7 @@ export const DropdownToggle: React.FunctionComponent<DropdownToggleProps> = ({
styles.dropdownToggle,
styles.modifiers.splitButton,
splitButtonVariant === 'action' && styles.modifiers.action,
(toggleVariant === 'primary' || isPrimary) && splitButtonVariant === 'action' && styles.modifiers.primary,
toggleVariant === 'primary' && splitButtonVariant === 'action' && styles.modifiers.primary,
toggleVariant === 'secondary' && splitButtonVariant === 'action' && styles.modifiers.secondary,
isDisabled && styles.modifiers.disabled
)}
Expand Down
5 changes: 0 additions & 5 deletions packages/react-core/src/components/Dropdown/Toggle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ export interface ToggleProps {
isPlain?: boolean;
/** Display the toggle in text only mode */
isText?: boolean;
/** @deprecated Use `toggleVariant` instead. Display the toggle with a primary button style */
isPrimary?: boolean;
/** Style the toggle as a child of a split button */
isSplitButton?: boolean;
/** Alternate styles for the dropdown toggle button */
Expand Down Expand Up @@ -64,7 +62,6 @@ export class Toggle extends React.Component<ToggleProps> {
isDisabled: false,
isPlain: false,
isText: false,
isPrimary: false,
isSplitButton: false,
onToggle: () => {},
onEnter: () => {},
Expand Down Expand Up @@ -138,7 +135,6 @@ export class Toggle extends React.Component<ToggleProps> {
isDisabled,
isPlain,
isText,
isPrimary,
isSplitButton,
toggleVariant,
onToggle,
Expand Down Expand Up @@ -166,7 +162,6 @@ export class Toggle extends React.Component<ToggleProps> {
isActive && styles.modifiers.active,
isPlain && styles.modifiers.plain,
isText && styles.modifiers.text,
isPrimary && styles.modifiers.primary,
toggleVariant && buttonVariantStyles[toggleVariant],
className
)}
Expand Down