fix(FileUpload): Improving events in the FileUpload

[wojta]

What: Closes #5545

What changes?

• onChange is now split in more events, old event remain there for the compatibility
• onTextChange - when text area changes (@mturley edit: renamed from onTextChanged)
• onFileInputChange - called when internal <input> field emits its own onChange DOM event (@mturley edit: renamed from onInputChange)
• onDataChange - when data is loaded in the component (@mturley edit: renamed from onDataChanged)
• onClearClick - when clear button is clicked (@mturley edit: renamed from onClearClicked)
• react-dropzone upgraded to the 10.2.2

[patternfly-build]

PF4 preview: https://patternfly-react-pr-6139.surge.sh
A11y report: https://patternfly-react-pr-6139-a11y.surge.sh

Preview: https://patternfly-react-pr-6139.surge.sh

[nicolethoen]

So far the new properties make sense to me! :)

[wojta]

I agreed with @christianvogt on adding onInputChanged that will do same as the input's onChange. No I fully understand the goal of the task is to provide replacement for HTML input type=file , but keeping the same implementation approach.

[mturley]

@wojta do you have an opinion on #3966 ? I think it might make sense to also remove the dropzoneProps and expose new props to meet the use cases we were solving by opening those props up. The consumer shouldn't necessarily need to know/care about Dropzone.

[redallen]

Thanks for your perseverance @wojta !

[mturley]

This largely looks great, but I have a couple of thoughts here. @redallen @nicolethoen do you think it is worth holding this PR up for these changes? I'd be happy to push a commit to this branch if you agree with the feedback since @vojtechszocs may be unavailable.

Looking at how this relates to #3966, I think we can follow up on that in a separate PR since it'll take consideration on how to deprecate dropzoneProps without removing it. I just think maybe the tweaks here will prevent merging some minor tech debt.

[mturley]

I think since this is still a beta component, maybe we can just remove this rather than deprecate it?

Edit: ah... I missed when we promoted this from beta. I should have followed up on #3966 sooner 😆

[tlabaj]

can we change the wording here a bit. The Please use rather the individual events is a bit confusing.

[mturley]

How about "A callback for when the file contents change. Please instead use onFileInputChange, onTextChange, onDataChange, onClearClick individually."?

I'm also realizing I didn't propagate some of these changes to the examples markdown. Fixing now as well.

[mturley]

@tlabaj I pushed fixes for these and rebased.

[redallen]

I think it's worth holding up and it's okay for you to push to this branch @mturley .

[mturley]

@redallen I pushed commits to resolve my comments. I also renamed the onTextChanged and onDataChanged to onTextChange and onDataChange respectively, to be consistent with the onFileInputChange and onChange naming tense.

[mturley]

Also onClearClicked -> onClearClick, missed that one.

[nicolethoen]

@kmcfaul @tlabaj this is ready for a final review

[tlabaj]

Looks great. Jut a couple of small nits

[tlabaj]

can we change the wording here a bit. The Please use rather the individual events is a bit confusing.