@patternfly/react-console: Remove unnecessary peer dependencies#1021
Merged
tlabaj merged 1 commit intopatternfly:masterfrom Dec 12, 2018
Merged
@patternfly/react-console: Remove unnecessary peer dependencies#1021tlabaj merged 1 commit intopatternfly:masterfrom
tlabaj merged 1 commit intopatternfly:masterfrom
Conversation
Contributor
Author
Collaborator
|
PatternFly-React preview: https://1021-pr-patternfly-react-patternfly.surge.sh |
Contributor
|
Thanks @vojtechszocs , I'm fine with removing these peerDeps as they are provided by patternfly-react. |
Pull Request Test Coverage Report for Build 3493
💛 - Coveralls |
jeff-phillips-18
approved these changes
Dec 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to
kubevirt-web-ui-componentsissue 136.Main
patternfly-reactpackage declarespatternflyandreact-bootstrapas regular dependencies, which pulls them into the consuming application's dependency tree.However,
@patternfly/react-consolepackage declarespatternflyandreact-bootstrapas peer dependencies (in addition to having a peer dependency onpatternfly-react, which in turn pulls these two specific libraries as regular dependencies).Aside from the fact that code in
@patternfly/react-consolepackage doesn't link to neitherpatternflynorreact-bootstrap, this breaks the rule established by mainpatternfly-reactpackage - treating those two specific libraries as regular dependencies, pulled transitively into the consuming application's dependency tree.Having too many peer dependencies can snowball into tons of warnings in consuming libraries and/or applications. Let's try not to introduce additional peer dependencies unless we have a compelling reason to do so.