Open peer dependencies to include angular 6 #352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patternfly-build
approved these changes
May 17, 2018
|
Although initial testing showed the current version of patternfly-ng runs with Angular 6, I'm closing this after the challenges noted in #356. We will likely create a new major version of patternfly-ng that's built with Angular 6 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested using the latest angular-cli and built with
ng --prod. My Angular 6 based app built and ran patternfly-ng components without error.Note that angular-cli isn't without its own issues. I encountered this problem along the way, but was able to apply the suggested workaround.
aws-amplify/amplify-js#678
The angular-cli application also required rxjs-compat 6.1.0.