Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package): Allow .json extension on annotations file (issue #836) #886

Merged
merged 1 commit into from
Jul 13, 2018

Conversation

engelfrost
Copy link
Member

Closes #836

Summary of changes:
Read annotations.json if it exists.
Else read annotations.js.

Not sure if being able to read the old file is a necessary convenience. If not, that part of the code (the else statement) can easily be removed.

@engelfrost
Copy link
Member Author

I realized I may have misunderstood the file naming convention - when do I use _ and when do I use camelCase?

@bmuenzenmeyer
Copy link
Member

@engelfrost thank you so much for the contribution! I will take a look at it ASAP.

I realized I may have misunderstood the file naming convention - when do I use _ and when do I use camelCase?

camelCase is my newer convention. when I started writing the app I was using underscores but have never went through and changed them all. Probably a good refactor task at some point

@bmuenzenmeyer bmuenzenmeyer merged commit 4048bf9 into pattern-lab:dev Jul 13, 2018
@bmuenzenmeyer
Copy link
Member

@engelfrost Thank you so much my friend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants