Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 47 additions & 18 deletions apps/server/src/serverRuntimeStartup.reconcile.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ it.effect.each(
);
const fallbackProviderInstanceId = ProviderInstanceId.make("claudeAgent");
const continuationSent = yield* Deferred.make<void>();
const continuationRunning = yield* Deferred.make<void>();
const continuationCleared = yield* Deferred.make<void>();
const sends: ProviderSendTurnInput[] = [];
const dispatched: OrchestrationCommand[] = [];
Expand Down Expand Up @@ -288,16 +289,20 @@ it.effect.each(
},
dispatch: (command) =>
Effect.sync(() => dispatched.push(command)).pipe(
Effect.flatMap(() => {
const runningCount = dispatched.filter(
(entry) =>
entry.type === "thread.session.set" && entry.session.status === "running",
).length;
return runningCount === 2
? Deferred.succeed(continuationRunning, undefined)
: Effect.void;
}),
Effect.as({ sequence: dispatched.length }),
),
});
assert.isTrue(
dispatched.every(
(command) =>
command.type === "thread.session.set" && command.session.status === "starting",
),
);
yield* Deferred.await(continuationSent);
yield* Deferred.await(continuationRunning);
yield* Deferred.await(continuationCleared);

assert.deepStrictEqual(
Expand All @@ -313,28 +318,50 @@ it.effect.each(
},
],
);
assert.deepStrictEqual(
dispatched.map((command) =>
command.type === "thread.session.set"
? {
const sessionSets = dispatched.flatMap((command) =>
command.type === "thread.session.set"
? [
{
threadId: command.threadId,
status: command.session.status,
activeTurnId: command.session.activeTurnId,
}
: null,
),
},
]
: [],
);
const byThreadId = (left: { threadId: ThreadId }, right: { threadId: ThreadId }) =>
String(left.threadId).localeCompare(String(right.threadId));
assert.deepStrictEqual(
sessionSets
.filter((command) => command.status === "starting")
.slice()
.sort(byThreadId),
[
{ threadId: codex.id, status: "starting" as const, activeTurnId: null },
{ threadId: fallback.id, status: "starting" as const, activeTurnId: null },
]
.slice()
.sort(byThreadId),
);
assert.deepStrictEqual(
sessionSets
.filter((command) => command.status === "running")
.slice()
.sort(byThreadId),
[
{
threadId: codex.id,
status: "starting",
activeTurnId: null,
status: "running" as const,
activeTurnId: TurnId.make(`continued-${String(codex.id)}`),
},
{
threadId: fallback.id,
status: "starting",
activeTurnId: null,
status: "running" as const,
activeTurnId: TurnId.make(`continued-${String(fallback.id)}`),
},
],
]
.slice()
.sort(byThreadId),
);
for (const [thread, continuationTurnId] of [
[codex, codex.session.activeTurnId],
Expand Down Expand Up @@ -909,6 +936,8 @@ for (const preparedStatus of [
assert.deepStrictEqual(sends, [
{ threadId: thread.id, continuation: true, interactionMode: "default" },
]);
assert.equal(thread.session.status, "running");
assert.equal(thread.session.activeTurnId, TurnId.make("turn-recovered"));
assert.deepStrictEqual(binding.runtimePayload, {
activeTurnId: null,
continueAfterServerUpdate: null,
Expand Down
19 changes: 18 additions & 1 deletion apps/server/src/serverRuntimeStartup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -705,13 +705,30 @@ export const reconcileProviderSessions = Effect.gen(function* () {
});
}
const capabilities = yield* providerService.getCapabilities(providerInstanceId);
yield* providerService.sendTurn({
const result = yield* providerService.sendTurn({
threadId: thread.id,
...(capabilities.promptlessTurnContinuation === true
? { continuation: true }
: { input: SERVER_UPDATE_CONTINUATION_PROMPT }),
interactionMode: thread.interactionMode,
});
// Resume/continuation often does not emit turn.started until the
// replacement turn finishes. Leave the session running with the
// admitted turn id so queue.steer is not blocked for the whole turn.
const continuedAt = DateTime.formatIso(yield* DateTime.now);
yield* orchestrationEngine.dispatch({
type: "thread.session.set",
commandId: CommandId.make(yield* crypto.randomUUIDv4),
threadId: thread.id,
session: {
...session,
status: "running",
activeTurnId: result.turnId,
lastError: null,
updatedAt: continuedAt,
},
createdAt: continuedAt,
});
});
const continuationExit = yield* Effect.exit(continuation);
if (Exit.isSuccess(continuationExit) || Cause.hasInterrupts(continuationExit.cause)) {
Expand Down
21 changes: 17 additions & 4 deletions apps/web/src/components/files/fileEditorLanguageReadiness.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ const source = "export const View = () => <div>Ready</div>;";
let pool: WorkerPoolManager;
let renderer: FileRenderer;
let terminationPromises: Promise<number>[];
let animationFrames: Set<ReturnType<typeof setImmediate>>;

class WorkerTransport {
private readonly worker = new NodeWorkerThreads.Worker(
Expand Down Expand Up @@ -96,10 +97,19 @@ function firstEnter(highlighter: DiffsHighlighter, file: FileContents, language:

beforeEach(async () => {
terminationPromises = [];
vi.stubGlobal("requestAnimationFrame", (callback: FrameRequestCallback) =>
setImmediate(() => callback(0)),
);
vi.stubGlobal("cancelAnimationFrame", clearImmediate);
animationFrames = new Set();
vi.stubGlobal("requestAnimationFrame", (callback: FrameRequestCallback) => {
const frame = setImmediate(() => {
animationFrames.delete(frame);
callback(0);
});
animationFrames.add(frame);
return frame;
});
vi.stubGlobal("cancelAnimationFrame", (frame: ReturnType<typeof setImmediate>) => {
animationFrames.delete(frame);
clearImmediate(frame);
});
vi.stubGlobal("window", { matchMedia: () => ({ matches: true }) });
await disposeHighlighter();
pool = new WorkerPoolManager(
Expand All @@ -116,6 +126,9 @@ afterEach(async () => {
pool?.terminate();
await Promise.all(terminationPromises);
await disposeHighlighter();
// Pool termination can queue a final broadcast after its workers have exited.
for (const frame of animationFrames) clearImmediate(frame);
animationFrames.clear();
vi.unstubAllGlobals();
});

Expand Down
Loading