Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent invalid ratio calculation and fitting #36

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/ng-FitText.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,12 @@
var maxFontSize = attrs.fittextMax || config.max || Number.POSITIVE_INFINITY;

var resizer = function() {
if ( element[0].offsetHeight * element[0].offsetWidth === 0 ) {
// Skip setting the font size if the element height or width
// have been set to 0 (or auto) for any reason.
return;
}

element[0].style.fontSize = '10px';
var ratio = element[0].offsetHeight / element[0].offsetWidth / nl;
element[0].style.fontSize = Math.max(
Expand Down