You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Definitely happy with this! I really like the clear explanation of output_padding. Do you think it’s worthwhile to include output_shape as an optional argument (that would have to agree with output_padding, if given), as haiku has done? While this could make model building more intuitive, specifying output_padding enables input images of varying sizes in the case of encoder-decoder style architectures, while output_shape could place too much of a restriction. I don’t think it’d be super important/useful to include it. Flax doesn’t seem to include either of these, as noted in google/flax#1872.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@andyehrenberg I think I've got transposed convolutions sorted out.
WDYT? If you're happy with this then I'll merge this in to the other ongoing feature branch.
The main references I used to implement this were Relation 14 of this reference and these animations.