Skip to content

Commit

Permalink
Fix signature help panic when too large (helix-editor#4030)
Browse files Browse the repository at this point in the history
When signature help is too large it may cause a panic when it is too
large, now I just make the hover do an intersection with surface to make
sure it never overflow.
  • Loading branch information
pickfire authored and pathwave committed Nov 4, 2022
1 parent 7713e7c commit 839f725
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion helix-term/src/ui/lsp.rs
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,9 @@ impl Component for SignatureHelp {

let (_, sig_text_height) = crate::ui::text::required_size(&sig_text, area.width);
let sig_text_area = area.clip_top(1).with_height(sig_text_height);
let sig_text_area = sig_text_area.inner(&margin).intersection(surface.area);
let sig_text_para = Paragraph::new(sig_text).wrap(Wrap { trim: false });
sig_text_para.render(sig_text_area.inner(&margin), surface);
sig_text_para.render(sig_text_area, surface);

if self.signature_doc.is_none() {
return;
Expand Down

0 comments on commit 839f725

Please sign in to comment.